Skip to content

Feature/toolbar component ui#235

Merged
marecar3 merged 38 commits intomasterfrom
feature/toolbar_component_ui
Nov 22, 2018
Merged

Feature/toolbar component ui#235
marecar3 merged 38 commits intomasterfrom
feature/toolbar_component_ui

Conversation

@marecar3
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 commented Nov 13, 2018 •
edited
Loading

Description

This PR resolves part of the Toolbar issue. It implements Toolbar and Toolbar Button style by the specs.

What's done :

Implement Toolbar Style

  • Implement toolbar button style by specs
  • Implement toolbar style by specs

selected_state

How has this been tested?

It is tested against this PR

@marecar3 marecar3 requested review from etoledom, hypest and koke November 13, 2018 22:50
@marecar3 marecar3 mentioned this pull request Nov 13, 2018
Merged
2 tasks
@iamthomasbishop
Copy link
Copy Markdown
Contributor

iamthomasbishop commented Nov 13, 2018 •
edited
Loading

This looks great overall! I'm not sure if this is the place to raise the request, but I have a couple minor requests:

  • Can we make sure the Inserter icon is the filled version, and using the primary WP blue?

  • I think the padding around the Inserter button could be tightened up. The padding on the left side of the first divider above can be removed so that the button (44x44) and divider are flush, unlike the other tools. The same thing will be applied to undo/redo if we decide to add those to the toolbar.

  • One other thing I missed in the initial review on slack dm. Can we make the inactive buttons/icons $grey and use $grey-dark for the active buttons (maybe this is already what you're using, just want to ensure a nice contrast)

For reference:
screen shot 2018-11-13 at 5 00 51 pm

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Nov 19, 2018

UI is updated by latest specs.
@etoledom now it's ready for review!

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Nov 21, 2018

Hey @marecar3 !
I see you are still working on the gutenberg side (WordPress/gutenberg#11827)

I did a fast test and I noticed something odd on iOS, it looks like the selection colors are inverted:

screen shot 2018-11-20 at 9 02 28 pm

@marecar3
Copy link
Copy Markdown
Contributor Author

marecar3 commented Nov 21, 2018

Hey @etoledom!

It seems that you maybe don't have the latest code on your local machine. You can pull it and you will have the latest changes.

Also, we have moved a conversation to gutenberg - WordPress/gutenberg#11827
sorry about that!

koke
koke approved these changes Nov 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once the issues with the tests are resolved

@marecar3 marecar3 merged commit 1f606a5 into master Nov 22, 2018
@marecar3 marecar3 deleted the feature/toolbar_component_ui branch November 22, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koke koke koke approved these changes

@hypest hypest Awaiting requested review from hypest

@etoledom etoledom Awaiting requested review from etoledom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marecar3 @iamthomasbishop @etoledom @koke