Implemented keyboard hide button#241
Merged
marecar3 merged 13 commits intofeature/toolbar_component_uifrom Nov 22, 2018
Merged
Conversation
Implemented keyboard hide button
…onent_keyboard_hide_button # Conflicts: # package.json # yarn.lock
…onent_keyboard_hide_button
2 tasks
…onent_keyboard_hide_button # Conflicts: # gutenberg
Contributor
Author
|
@daniloercoli has a good point regarding this one. As it is working with block |
Contributor
Author
|
Thanks @marecar3 |
…onent_keyboard_hide_button # Conflicts: # src/block-management/block-manager.js
Member
|
I just tested this one on an iPhone 8 and I'm not seeing the toolbar when the keyboard is up. I noticed this is against |
…onent_keyboard_hide_button # Conflicts: # src/block-management/block-manager.js
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added keyboard hide button in Toolbar.
Note: Currently we can't dismiss keyboard as we are missing some logic on the Aztec level which will expose
focus()andblur()methods. That should be done in separate ticket and probably @mzorz can look at it.