Skip to content

Remove Keyboard.dismiss when deleting block#2327

Merged
lukewalczak merged 2 commits intodevelopfrom
fix/remove_keyboard_dismiss
May 27, 2020
Merged

Remove Keyboard.dismiss when deleting block#2327
lukewalczak merged 2 commits intodevelopfrom
fix/remove_keyboard_dismiss

Conversation

@lukewalczak
Copy link
Copy Markdown
Contributor

@lukewalczak lukewalczak commented May 27, 2020

It can fix: wordpress-mobile/WordPress-Android#10491

Ref to gutenberg: WordPress/gutenberg#22677
To test:

  1. Open mobile app
  2. Open new draft post
  3. Add Media&Text, ContactInfo or any block
  4. Remove Media&Text block
  5. The app cannot crash

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented May 27, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Copy Markdown
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukewalczak 👍

Once these are merged we can cherry-pick the gutenberg commit over to the gutenberg rnmobile/release-1.29.0 branch and then update the submodule ref on the gutenberg-mobile release/1.29.0 branch. I can take care of that if you want to ping me when these are merged.

@lukewalczak lukewalczak merged commit e8e1ffd into develop May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IllegalViewOperationException: Unable to execute operation dispatchViewManagerCommand on view with tag: 159, since the view does...

2 participants