[RNMobile] Remove Keyboard.dismiss when deleting block#22677
Merged
lukewalczak merged 1 commit intomasterfrom May 27, 2020
Merged
[RNMobile] Remove Keyboard.dismiss when deleting block#22677lukewalczak merged 1 commit intomasterfrom
lukewalczak merged 1 commit intomasterfrom
Conversation
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
SergioEstevao
approved these changes
May 27, 2020
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
I tested this, on iOS and Android, by adding and deleting all blocks available and it worked well for me.
Let's just have @mchowning double-check before we merge this.
mchowning
approved these changes
May 27, 2020
Contributor
mchowning
left a comment
There was a problem hiding this comment.
Tested on Android and I don't see any issues. Thanks @lukewalczak ! 🙇
2 tasks
This was referenced May 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the line with
Keyboard.dismiss()which could be the cause of crash on Android when newly added block such as:Media&Text,Contact InfoIt can fix: wordpress-mobile/WordPress-Android#10491
Ref to gutenberg mobile: wordpress-mobile/gutenberg-mobile#2327
How has this been tested?
Media&Text,ContactInfoor any blockMedia&TextblockScreenshots
Types of changes
Checklist: