Skip to content

[FIX] Cover block background when there's a video is totally black#2146

Merged
dratwas merged 1 commit intodevelopfrom
fix/cover-video-background
Apr 15, 2020
Merged

[FIX] Cover block background when there's a video is totally black#2146
dratwas merged 1 commit intodevelopfrom
fix/cover-video-background

Conversation

@dratwas
Copy link
Copy Markdown
Contributor

@dratwas dratwas commented Apr 9, 2020 •
edited
Loading

Fixes #2104

Gutenberg PR - WordPress/gutenberg#21508

To test:

  • Run Wordpress-Android with the packager
  • Add a cover block and set video as a background
  • the background should be set to the same as a placeholder until the video is loaded

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dratwas dratwas mentioned this pull request Apr 9, 2020
Merged
6 tasks
@dratwas dratwas requested review from geriux and hypest April 9, 2020 16:53
@pinarol pinarol requested review from mkevins and removed request for geriux and hypest April 14, 2020 09:51
@pinarol pinarol added this to the 1.27 milestone Apr 14, 2020
mkevins
mkevins approved these changes Apr 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via: WordPress/gutenberg#21508 (review) LGTM!

@dratwas dratwas force-pushed the fix/cover-video-background branch from 5575d81 to 91aad24 Compare April 15, 2020 12:15
@dratwas dratwas force-pushed the fix/cover-video-background branch from 91aad24 to 817033a Compare April 15, 2020 13:24
@dratwas dratwas merged commit 0246cb6 into develop Apr 15, 2020
@dratwas dratwas deleted the fix/cover-video-background branch April 15, 2020 14:09
This was referenced Apr 27, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mkevins mkevins mkevins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.27

Development

Successfully merging this pull request may close these issues.

Cover block background when there's a video is totally black

3 participants

@dratwas @mkevins @pinarol