[RNMobile][FIX] Cover block background when there's a video is totally black#21508
Merged
[RNMobile][FIX] Cover block background when there's a video is totally black#21508
Conversation
|
Size Change: 0 B Total Size: 904 kB ℹ️ View Unchanged
|
2 tasks
Contributor
|
hey @mkevins could you review this one? |
Contributor
Yes 👍 |
Contributor
|
Hi @dratwas 👋 😃 This looks good from a code perspective. For some reason, I see slightly darker colors in dark mode compared to the placeholder:
Is this expected / do you see the same? Other than that, it's working as expected. 👍 |
Contributor
Author
Hey @mkevins , it is the same for the image. This is darker because of the overlay that is set to 50%. We could hide the overlay while the video/image is loading as well. WDYT? |
mkevins
approved these changes
Apr 15, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Hey @mkevins , it is the same for the image. This is darker because of the overlay that is set to 50%. We could hide the overlay while the video/image is loading as well. WDYT?
Ah, that makes sense! Since it's the same for image, I think it is good the way it is (especially since the loading background color was not considered an issue for image). Nice work! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes wordpress-mobile/gutenberg-mobile#2104
Gutenberg-mobile PR - wordpress-mobile/gutenberg-mobile#2146
The Video component from
react-native-videohas a black background on Android even if i set thebackgroundColorin style. In this PR I hide the Video component until the video is loaded.How has this been tested?
Screenshots
Types of changes
Fix black background while the video is loading
Checklist: