Skip to content

Align plus icon for the iOS Stepper control#2116

Merged
chipsnyder merged 2 commits intodevelopfrom
issue/2026-stepperIcon
Apr 8, 2020
Merged

Align plus icon for the iOS Stepper control#2116
chipsnyder merged 2 commits intodevelopfrom
issue/2026-stepperIcon

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Apr 6, 2020

Fixes: #2026
gutenberg: WordPress/gutenberg#21434

Description

Aligns the ➕ icon on the iOS stepper control to the middle of its container. Note this only applies to iOS as Android uses a chevron.

How has this been tested?

  1. Select a Gallery block with multiple images
  2. Open settings with mobile toolbar settings button
  3. Check the Stepper buttons

Screenshots

Screen Shot 2020-04-06 at 2 01 51 PM

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link
Copy Markdown
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#21434 (review) . Works as expected. LGTM!

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Apr 8, 2020

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

1 similar comment
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger optional full suite of UI tests for these changes by visiting CircleCI here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The icons in BottomSheet Stepper cell should be align

2 participants