Skip to content

Enable Dismiss on PlainText in Android#1871

Merged
chipsnyder merged 2 commits intorelease/1.22.0from
issue/1864-shortcode-keyboard
Feb 7, 2020
Merged

Enable Dismiss on PlainText in Android#1871
chipsnyder merged 2 commits intorelease/1.22.0from
issue/1864-shortcode-keyboard

Conversation

@chipsnyder
Copy link
Copy Markdown
Contributor

@chipsnyder chipsnyder commented Feb 7, 2020

Fixes #1864

Related PRs:
gutenberg-pr: WordPress/gutenberg#20095

To test:

Blocks with PlainText:

  • code
  • shortcode

Existing Field

  1. Open a page or post with a block that uses the PlainText component.
  2. Click on the field
  3. Edit or leave unchanged
  4. Click the keyboard dismiss button
    Expect the keyboard to dismiss

New Field

  1. Select to add a new component with the PlainText component
    Expect the keyboard to dismiss
  2. Add text or leave blank
  3. Click the keyboard dismiss button
    Expect the keyboard to dismiss

Screen Recording 2020-02-07 at 8 53 25 AM 2020-02-07 08_58_12

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder force-pushed the issue/1864-shortcode-keyboard branch from ffd9014 to 39df39b Compare February 7, 2020 14:37
Copy link
Copy Markdown
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @chipsnyder!

@marecar3
Copy link
Copy Markdown
Contributor

marecar3 commented Feb 7, 2020

Don't forget to update the reference 😄 ( after merging )

@chipsnyder chipsnyder merged commit 4ef6a4b into release/1.22.0 Feb 7, 2020
@chipsnyder chipsnyder deleted the issue/1864-shortcode-keyboard branch February 7, 2020 19:09
This was referenced Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] Keyboard dismiss button doesn't dismiss the keyboard in the Shortcode block

2 participants