Enable Dismiss on PlainText in Android#1871
Merged
chipsnyder merged 2 commits intorelease/1.22.0from Feb 7, 2020
Merged
Conversation
6 tasks
ffd9014 to
39df39b
Compare
marecar3
approved these changes
Feb 7, 2020
Contributor
marecar3
left a comment
There was a problem hiding this comment.
LGTM! Nice work @chipsnyder!
Contributor
|
Don't forget to update the reference 😄 ( after merging ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1864
Related PRs:
gutenberg-pr: WordPress/gutenberg#20095To test:
Blocks with PlainText:
Existing Field
Expect the keyboard to dismiss
New Field
Expect the keyboard to dismiss
Expect the keyboard to dismiss
PR submission checklist:
RELEASE-NOTES.txtif necessary.