Conversation
# Conflicts: # gutenberg
Merge master (v1.13.0) back to develop
…e into feature/move-media-upload-progress
|
We want to target |
Absolutely 😁 |
WPAndroid updating to Gradle 5.4.1 caused a build failure when BUILD_GUTENBERG_FROM_SOURCE was set to true because the react-native-gutenberg-bridge could not access the WordPressUtils. In particular, the WPAndroidGlueCode class would fail to import org.wordpress.android.util.AppLog, causing a compilation error. Switching WordPressUtils from an implementation dependency to an api dependency in react-native-aztec resolves this problem.
| * Fix issue when force Touch app shortcut doesn't work properly selecting "New Photo Post" on iOS | ||
| * Add Link Target (Open in new tab) to Image Block. | ||
| * [iOS] DarkMode improvements. | ||
| * [iOS] Update to iOS 11 and Swift 5 |
There was a problem hiding this comment.
I like this "[Platform] changes" format for platform-specific changes. I think I'll use this format going forward.
There was a problem hiding this comment.
I'm not sure about [iOS] Update to iOS 11 and Swift 5, since it's not an user facing change.
There was a problem hiding this comment.
Well, that is a fair point. 😄
There was a problem hiding this comment.
Some context on why I added it: since we also add some notes to the GitHub Release of the library itself, I figured that such upgrade is important to mention there. And indeed, it's not user facing so, happy it didn't reach the release-notes in the main app.
Maybe we can starting thinking of a way to denote this kind of "news" that are important/non-trivial for the library but not useful to bubble up to the main apps.
There was a problem hiding this comment.
That's a good idea. If you look at core releases, there's often the news for users, and then a section of changes for developers.
Release for Gutenberg Mobile v1.15.0
Related PRs:
To test:
Update release notes:
RELEASE-NOTES.txt.