Image Block: Adding example block with image.#143
Merged
Conversation
This was referenced Sep 13, 2018
Closed
Contributor
Heh, can anyone be super happy seeing unfinished functionality?! Well, I'm among those people ;) Thanks for the nice execution of the "just focus on small steps" mentality @etoledom 🙇♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #140
This PR implements the changes on the
Gutenbergproject to display the content of an image block, or the empty block UI.To be able to test them, this PR also adds an extra example block with an image to be displayed.
The buttons to add images do nothing. That's fine for now :)
To test:
06793a.