Merged
Conversation
…laceholder/index.native.js`
mzorz
approved these changes
Sep 14, 2018
| const { url } = attributes; | ||
|
|
||
| const onUploadPress = () => { | ||
| }; |
Contributor
There was a problem hiding this comment.
Minor nit: I'd add some console.log() here to indicate this has been pressed, and also we could use a TODO comment in code in the function body to mark this as something we need to implement
Contributor
Author
There was a problem hiding this comment.
eslint seems to not like console.logs:
error Unexpected console statement no-console
But I'll add the TODO comment for future references.
Thank you!
Contributor
There was a problem hiding this comment.
Oh! 😅 makes sense 👍 thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to recognize an empty image block and one with content, showing the appropriate UI in each case.
This was implemented following the web version as an example, trying to recreate the same structure on mobile.
The UI is temporary and most of the code will probably change in the near future.
For now, the image is being downloaded directly by the
<Image>component, but in the future, it might be better to let the main app to handle both downloads and uploads.Screenshots
For testing, please refer to the Gutenberg Mobile PR
cc @hypest