Move AppContainer and MainScreen to @wordpress/edit-post as Editor and Layout#1171
Merged
Move AppContainer and MainScreen to @wordpress/edit-post as Editor and Layout#1171
Conversation
5 tasks
10 tasks
etoledom
approved these changes
Jun 25, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks and works great! 🎉
Tested on iOS and Android
There are a couple of errors when I run yarn flow locally. Weird since the CI is ✅
Most probably is some local state of mine.
Great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 8b of #958
This is a refactor PR, the goal is to move our remaining components to gutenberg.
Gutenberg PR WordPress/gutenberg#16260
Changes
App(src/app/App.js) -> included inRootComponentinsrc/index.jsAppContainer(src/app/AppContainer.js) -> renamed toEditorand moved togutenberg/packages/edit-post/src/editor.native.jsMainScreen(src/app/MainScreen.js) -> renamed toLayoutand moved togutenberg/packages/edit-post/src/components/layout/index.native.jssrc/app/App.test.js-> moved tosrc/index.test.js(cannot be moved to gutenberg at this point as it uses the initial-html as input)src/app/AppContainer.test.js-> moved togutenberg/packages/edit-post/src/test/editor.native.jssrc/app/style.scss-> moved togutenberg/packages/edit-post/src/components/layout/style.native.jssrc/app/initial-html.js-> moved tosrc/initial-html.jsTesting Instructions
Update release notes:
RELEASE-NOTES.txt.