Add Editor and Layout in @wordpress/edit-post (Ported from Gutenberg Mobile)#16260
Merged
Add Editor and Layout in @wordpress/edit-post (Ported from Gutenberg Mobile)#16260
Conversation
1 task
10 tasks
etoledom
approved these changes
Jun 25, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Great job! 🎉
Tested via wordpress-mobile/gutenberg-mobile#1171 (review)
JS unit test are failing on CI, but they are passing locally.
Maybe retrying will help!
67f82bb to
7249027
Compare
Contributor
Author
|
@etoledom Thanks fo the review 🎉
I rebased but they're failing on master as well |
Contributor
|
I think that the changes related to what happens on html/visual mode switch introduced a regression (Case A in wordpress-mobile/WordPress-Android#10092 (comment)). Any context about why the mode change tries to send data to the the parent app? @Tug , can you elaborate about these lines? : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is step 8b of wordpress-mobile/gutenberg-mobile#958
This PR ports the gutenberg-mobile AppContainer and MainScreen to gutenberg as the Editor and Layout components inside
@wordpress/edit-post.This is not needed to implement Inner blocks for mobile native but is a nice improvement which will help port the remaining of our code to gutenberg.
How has this been tested?
GB Mobile PR wordpress-mobile/gutenberg-mobile#1171
Types of changes
Adds native support for Editor and Layout
Checklist: