Conversation
…act-native-recyclerview-list
Align build tools and kotlin version with WPAndroid versions
|
Update: I pushed RN v0.60.0-rc.1, JSC-r241213 to the Bintray mirror. |
|
WPAndroid PR, at least for testing purposes: wordpress-mobile/WordPress-Android#10022 |
|
I tried to build the latest gutenberg-mobile develop with the wpandroid develop using binary artifacts (source mode off) and it works (including running the app and the editor) so, this PR is not a blocker for the v1.7 code freeze. Besides, this PR updates React Native to a RC version which we don't want to ship yet so, better to postpone anyway. |
Use v0.60.0 patch from jtreanor/react-native
Make Gutenberg.podspec depend on React pod to avoid Native Module errors
|
iOS side looks good to go! ✅ 🎉 Tested on the demo app and WPiOS via wordpress-mobile/WordPress-iOS#12056 |
|
As far as I can see, the Aztec PR is not green yet and needs more migration of the testsuites. I pushed a commit to fix some of them but more work is needed. Let's get it green before we merge the rest of the PR set so we can be more confident we haven't broken something. |
Update react-native-svg version
Ok, I will take care of that one @hypest |
So we don't need to make the client app directly import React Native classes.
|
👋 @daniloercoli , can you do another round of testing to mainly verify I didn't break something with 4107bf6? Thanks! |
hypest
left a comment
There was a problem hiding this comment.
This now looks good to me!
Issue: #1062
With this PR we are migrating
gutenberg-mobileandroid application to AndroidX.RN already provided AndroidX support so we are targeting RN60 with @jtreanor's patch for cocoapods in this PR
Libraries that are also migrated to AndroidX:
Aztec-Android
react-native-video
react-native-recyclerview-list
WPAndroid against this PR.
Note: As we are using the newest version of
jsc-android241213, should we push it on : https://dl.bintray.com/wordpress-mobile/react-native-mirror/org/webkit/android-jsc/ ? @hypest @jtreanor (not sure)Not working:Working ✅Gutenberg mobile tests,
enzymecomplains that adapter isn't set, I assume that it's something with RN60 version, maybe @etoledom can help here with some hint?WordPress-Android tests -> jitpack.io can't build
react-native-video-wordpressas it can't find RN60 at https://dl.bintray.com/wordpress-mobile/react-native-mirror/com/facebook/react/react-native/@hypest I am curios should we push RN60 there or maybe I just wrongly configured
react-native-videowordpress-mobile/react-native-video@enable-android-build-of-standalone-package...wordpress-mobile:experiment/android_x_migration#diff-3a56ae3cf3e05886fec69653e96f2456R53I must admit that I am not sure how build.gradle file should be configured as I saw that jitpack is trying to call this command:
./gradlew clean -Pgroup=com.github.wordpress-mobile -Pversion=57ad4e840a -xtest -xlint installinreact-native-video.Update release notes:
RELEASE-NOTES.txt.