Make Gutenberg.podspec depend on React pod to avoid Native Module errors#1198
Merged
jtreanor merged 2 commits intoissue/android_x_migrationfrom Jul 5, 2019
Merged
Make Gutenberg.podspec depend on React pod to avoid Native Module errors#1198jtreanor merged 2 commits intoissue/android_x_migrationfrom
jtreanor merged 2 commits intoissue/android_x_migrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1184 I reduced the RN pods that
Gutenberg.podspecdepends on. After seeing a fewNative module cannot be nullerrors I think its safer to depend on all ofReact. Otherwise there is a risk of shipping with a crash we don't realise.It also allows us to revert the podspec changes to all of our third party libraries.
I have also updated the WPiOS PR here: wordpress-mobile/WordPress-iOS#12056
Update release notes:
RELEASE-NOTES.txt.