Conversation
…iew to @wordpress/components
Generated by 🚫 dangerJS |
5 tasks
…dpress-components
pinarol
approved these changes
Jun 3, 2019
Contributor
pinarol
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Followed test instructions and couldn't catch any side effects.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is step 2 of our mobile refactor #958
Gutenberg PR: WordPress/gutenberg#15913
In this PR we're moving
KeyboardAvoidingView,KeyboardAwareFlatListandReadableContentViewfromsrc/componentstogutenberg/packages/components/src/mobile.The goal is to have them available on
gutenbergto be able to port other components there.Testing Instructions