Skip to content

Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to @wordpress/components#15913

Merged
Tug merged 3 commits intomasterfrom
rnmobile/add/wordpress-components
Jun 3, 2019
Merged

Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentView to @wordpress/components#15913
Tug merged 3 commits intomasterfrom
rnmobile/add/wordpress-components

Conversation

@Tug
Copy link
Copy Markdown
Contributor

@Tug Tug commented May 30, 2019 •
edited
Loading

This PR is step 2 of our mobile refactor wordpress-mobile/gutenberg-mobile#958

Description

Its goal is to port some of our reusable components that live in gutenberg-mobile to gutenberg so we can reuse them in gutenberg and thus port our other components as well.

How has this been tested?

Gutenberg mobile PR wordpress-mobile/gutenberg-mobile#1048

Types of changes

This is a refactor PR

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug added [Status] In Progress Tracking issues with work in progress Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels May 30, 2019
@Tug Tug self-assigned this May 30, 2019
@Tug Tug mentioned this pull request May 30, 2019
Merged
gziolo
gziolo reviewed May 30, 2019
View reviewed changes
packages/components/src/mobile/readable-content-view/style.scss Outdated
Copy link
Copy Markdown
Member

@gziolo gziolo May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename should be updated to style.native.scss to ensure it never gets included for the web version.

Copy link
Copy Markdown
Contributor Author

@Tug Tug May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated!

@Tug Tug force-pushed the rnmobile/add/wordpress-components branch from 5182c78 to be2709d Compare May 30, 2019 13:05
pinarol
pinarol approved these changes Jun 3, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with the steps in parent PR

@Tug Tug merged commit 2627415 into master Jun 3, 2019
@Tug
Copy link
Copy Markdown
Contributor Author

Tug commented Jun 3, 2019

Thanks for the review @pinarol 🙇

@Tug Tug deleted the rnmobile/add/wordpress-components branch June 3, 2019 07:54
@koke koke mentioned this pull request Jun 6, 2019
Closed
10 tasks
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
@youknowriad youknowriad removed the [Status] In Progress Tracking issues with work in progress label Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo left review comments

@pinarol pinarol pinarol approved these changes

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@Tug Tug

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Milestone

Gutenberg 5.9

Development

Successfully merging this pull request may close these issues.

4 participants

@Tug @gziolo @pinarol @youknowriad