This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Fix JetpackScan model parsing errors#309
Merged
emilylaguna merged 2 commits intodevelopfrom Dec 3, 2020
Merged
Conversation
3 tasks
| public let port: Int? | ||
| public let user: String? | ||
| public let path: String? | ||
| public let type: String |
Contributor
There was a problem hiding this comment.
Are you sure these others will always be present? Just wondering if we shouldn't change them to Optionals too...
Contributor
Author
There was a problem hiding this comment.
From what I can tell the type, role, stillValid are always present.
leandroalonso
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues while parsing the scan data:
context: ""(context is an empty string)isEnabledis always false becausedidSetis not called on initializationYou can test it using the following WPiOS PR: wordpress-mobile/WordPress-iOS#15427
Testing Details
Follow the testing steps on the PR here: wordpress-mobile/WordPress-iOS#15427