Jetpack Section: Adds Scan item to the My Site menu#15427
Merged
emilylaguna merged 9 commits intodevelopfrom Dec 3, 2020
Merged
Jetpack Section: Adds Scan item to the My Site menu#15427emilylaguna merged 9 commits intodevelopfrom
emilylaguna merged 9 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Dec 3, 2020
Closed
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
leandroalonso
requested changes
Dec 3, 2020
Contributor
leandroalonso
left a comment
There was a problem hiding this comment.
@emilylaguna it all works as described. But I think we're missing the Feature Flag for the Scan option?
| service.getScanAvailableForSite(siteID, success: success, failure: failure) | ||
| } | ||
|
|
||
| private func defaultApi() -> WordPressComRestApi { |
Contributor
There was a problem hiding this comment.
We have this in so many places that I wonder if we should extend WordPressComRestApi and add that as a static func.
We don't need to change the other places where this is used but it would be good to have a centralized place. Up to you anyway!
| }]]; | ||
| } | ||
|
|
||
| if ([self.blog supports:BlogFeatureJetpackScan]) { |
Contributor
There was a problem hiding this comment.
Since we're merging that to develop we should create a Feature Flag for it, no?
Contributor
Author
|
@leandroalonso Back to you! |
leandroalonso
approved these changes
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15190
Related WordPressKit PR: wordpress-mobile/WordPressKit-iOS#309
This PR adds the logic to display the Scan menu item for sites that support it. This does not include an icon or the correct action when tapping on the item yet.
Screenshots
To test:
Scan item appears
Expectation: the 'Scan' menu item appears under the 'Activity Log'
Scan doesn't appear for non-Jetpack Scan sites
Expectation: the 'Scan' menu item DOES NOT appear
PR submission checklist:
RELEASE-NOTES.txtif necessary.