Skip to content
This repository was archived by the owner on Sep 4, 2018. It is now read-only.

Add new events for Stats#26

Merged
astralbodies merged 4 commits intodevelopfrom
issue/25-insights-events
Jun 23, 2015
Merged

Add new events for Stats#26
astralbodies merged 4 commits intodevelopfrom
issue/25-insights-events

Conversation

@astralbodies
Copy link
Copy Markdown
Contributor

@astralbodies astralbodies commented Jun 23, 2015

Closes #25

  • Adds WPAnalyticsStatStatsInsightsAccessed for tracking when the insights screen is shown
  • Adds WPAnalyticsStatStatsPeriodStatsAccessed for tracking when the period stats (days/weeks/months/years) stats screen is shown. A parameter will be used to track which period is shown.
  • Adds WPAnalyticsStatLogSpecialCondition for help with logging weird events remotely - example is a scenario with JSON data causing a crash. Guard in place for the crash but the anomalous data is now going to be logged and analyzed through Tracks.
  • Keeps WPAnalyticsStatStatsAccessed for now to continue to track when any stats screen is presented.

cc: @daniloercoli for adding equivalent Android events (special condition one is optional)

Needs Review: @sendhil

@astralbodies
Decided to do individual enums for each period
f082eb5 
This is more of what we've done in the past.
@astralbodies
Copy link
Copy Markdown
Contributor Author

astralbodies commented Jun 23, 2015

Decided to switch WPAnalyticsStatStatsPeriodStatsAccessed to

    WPAnalyticsStatStatsPeriodDaysAccessed,
    WPAnalyticsStatStatsPeriodWeeksAccessed,
    WPAnalyticsStatStatsPeriodMonthsAccessed,
    WPAnalyticsStatStatsPeriodYearsAccessed,

This keeps the change in line with how we track multiple events right now that are related. In the actual implementation for the Nosara Tracks tracker, we'll turn these into properties.

@jleandroperez
Copy link
Copy Markdown
Contributor

jleandroperez commented Jun 23, 2015

Looking good Aaron! :shipit:

@astralbodies
Copy link
Copy Markdown
Contributor Author

astralbodies commented Jun 23, 2015

Thanks @jleandroperez!

astralbodies added a commit that referenced this pull request Jun 23, 2015
@astralbodies
Merge pull request #26 from wordpress-mobile/issue/25-insights-events
ddb6b51 
Add new events for Stats
@astralbodies astralbodies merged commit ddb6b51 into develop Jun 23, 2015
@astralbodies astralbodies deleted the issue/25-insights-events branch June 23, 2015 19:36
@daniloercoli daniloercoli mentioned this pull request Jun 24, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@astralbodies @jleandroperez