Merged
Conversation
- Defer appropriate tasks to the background queue - Add notifications manager class to declutter the AppDelegate - Remove iOS 6 appearance customization code
- Updates NotificationsManager and AppDelegate - Remove unused or soon to be unused (BetaUIWindow) notifications
xctool was trying to build for iOS6 because the WordPressTest target had an older target deployment
- Handle side-effects of doing so in other files
Conflicts: WordPress/Classes/WordPressAppDelegate.m
- Remove unused properties - Remove properties that are only ever used for one dead state (isUploadingPost, etc) - Lazy load file logger
added 3 commits
November 21, 2013 13:24
- The warning fixing should have been picked up from #608 but were not. - Give a bit more clarity to the stats/update checking via rename
Contributor
There was a problem hiding this comment.
I love everything about this.
Contributor
|
|
…nto issue/609 Conflicts: WordPress/Classes/BetaUIWindow.m WordPress/Classes/WordPressAppDelegate.m
Author
|
Merge build fails due to simulator failing to start, going to merge this anyways. |
pivotal-rebecca
pushed a commit
that referenced
this pull request
Nov 22, 2013
Clean up App delegate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various tasks