Skip to content

Issue/4328 Show No Results message when all sites are hidden#6208

Merged
frosty merged 2 commits intodevelopfrom
issue/4328-all-sites-hidden
Nov 17, 2016
Merged

Issue/4328 Show No Results message when all sites are hidden#6208
frosty merged 2 commits intodevelopfrom
issue/4328-all-sites-hidden

Conversation

@frosty
Copy link
Copy Markdown
Contributor

@frosty frosty commented Nov 17, 2016

Fixes #4328. I've added a variation on the no results view when all sites are hidden. The messaging should match Calypso's in the same situation.

simulator screen shot 17 nov 2016 18 49 53

To test:

  • Hide all sites, exit Edit mode and check the message appears as expected.
  • Check the message disappears when you re-show a site.
  • Check the existing 'no sites' message still appears when you have no sites whatsoever.

Needs review: @aerych

@frosty frosty added this to the 6.8 milestone Nov 17, 2016
@aerych aerych self-assigned this Nov 17, 2016
@aerych
Copy link
Copy Markdown
Contributor

aerych commented Nov 17, 2016

Looks solid @frosty :)
Code looks good to me. Tested in iPhone 6s and iPad Retina simulators and both worked perfectly.
:shipit: sir!

@frosty frosty merged commit 0bb33db into develop Nov 17, 2016
@frosty frosty deleted the issue/4328-all-sites-hidden branch November 17, 2016 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants