Data Model for My Profile/Account Settings#4520
Merged
Conversation
Contributor
|
Just tested this puppy (By installing it on top of Looking great sir!. One minor comment: Perhaps it'd be a good idea to keep things consistent, and have
|
on my side
Member
Author
|
Merging. I'm not sure I understand your comment about ManagedAccountSettings, but we can keep discussing it on #4510 |
koke
added a commit
that referenced
this pull request
Nov 26, 2015
…a-model Data Model for My Profile/Account Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding just the data model in a separate PR so it's merged as soon as possible to avoid conflicts
I had to add
AccountSettings.swiftsince the data model references the entity classRefs #4499, #4510
Needs Review: @jleandroperez