Skip to content

Fix failing UI tests after React Native upgrade in Gutenberg#21143

Merged
fluiddot merged 2 commits intogutenberg/tweak-pod-deps-by-rn-versionfrom
test/latest-wip-xcframework-and-ui-tests
Jul 20, 2023
Merged

Fix failing UI tests after React Native upgrade in Gutenberg#21143
fluiddot merged 2 commits intogutenberg/tweak-pod-deps-by-rn-versionfrom
test/latest-wip-xcframework-and-ui-tests

Conversation

@mokagio
Copy link
Copy Markdown
Contributor

@mokagio mokagio commented Jul 20, 2023 •
edited
Loading

Implements a working albeit not elegant workaround to the issue of UI tests not being able to get a handle on the keyboard when attempting to insert text in the title and paragraph blocks in the Gutenberg editor built and integrated via XCFramework.

As you can see, CI is green here, while it's red in the base branch.

Based on #21134. In that PR, @jostnes made a few suggestions of approaches to try. I haven't had a chance to do so yet. If you trust I'll followup on the approaches, I'd rather merge with the tests green as is sooner rather than later. 😅

Regression Notes

  1. Potential unintended areas of impact – N.A.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
  3. What automated tests I added (or what prevented me from doing so) – N.A.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes. N.A.
  • I have considered adding accessibility improvements for my changes. N.A.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

UI changes testing checklist: Not a UI PR.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 20, 2023 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr21143-4530832
Version22.8
Bundle IDcom.jetpack.alpha
Commit4530832
App Center Buildjetpack-installable-builds #5459
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented Jul 20, 2023 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr21143-4530832
Version22.8
Bundle IDorg.wordpress.alpha
Commit4530832
App Center BuildWPiOS - One-Offs #6431
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio mokagio added this to the Someday milestone Jul 20, 2023
@mokagio mokagio added the Testing Unit and UI Tests and Tooling label Jul 20, 2023
@mokagio mokagio requested review from SiobhyB and fluiddot July 20, 2023 04:03
@mokagio mokagio marked this pull request as ready for review July 20, 2023 04:03
@mokagio mokagio requested a review from a team as a code owner July 20, 2023 04:03
@fluiddot
Copy link
Copy Markdown
Contributor

fluiddot commented Jul 20, 2023

Thanks @mokagio for the fix 🙇 ! I'm a bit hesitant about this workaround because typing should be a testable action. However, I tried the approaches shared by @jostnes here but none have worked when running the tests locally 🤔. Hence, I agree with going with this approach for now, especially for the sake of unblocking the React Native upgrade. We could review later on a better approach.

fluiddot
fluiddot approved these changes Jul 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

  • Tests are passing in CI ✅
  • Running editor tests locally in Xcode succeed ✅

@fluiddot fluiddot merged commit 170d7f4 into gutenberg/tweak-pod-deps-by-rn-version Jul 20, 2023
@fluiddot fluiddot deleted the test/latest-wip-xcframework-and-ui-tests branch July 20, 2023 16:34
@fluiddot fluiddot mentioned this pull request Jul 20, 2023
Closed
4 tasks
mokagio added a commit that referenced this pull request Jul 21, 2023
@mokagio
Merge remote-tracking branch 'origin/trunk' into gutenberg/upgrade/re…
795a9c2 
…act-native-0.71.11

I addressed the conflicts in `BlockEditorScreen.swift` by keeping the
new query syntax from
#21122 and the
typing workaround from
#21143
@fluiddot fluiddot mentioned this pull request Jul 21, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiobhyB SiobhyB Awaiting requested review from SiobhyB

1 more reviewer

@fluiddot fluiddot fluiddot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Testing Unit and UI Tests and Tooling

Projects

None yet

Milestone

Someday

Development

Successfully merging this pull request may close these issues.

3 participants

@mokagio @wpmobilebot @fluiddot