Fix memory leaks on viewing a post from a notification#21013
Merged
Conversation
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21013-e44432e | |
| Version | 22.7 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e44432e | |
| App Center Build | jetpack-installable-builds #5238 |
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21013-e44432e | |
| Version | 22.7 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e44432e | |
| App Center Build | WPiOS - One-Offs #6212 |
mokagio
approved these changes
Jul 9, 2023
Contributor
mokagio
left a comment
There was a problem hiding this comment.
Tested on Simulator.
viewDidLoad called ✅
deinit called
| private let post: ReaderPost | ||
| private weak var delegate: ReaderCommentsFollowPresenterDelegate? | ||
| private let presentingViewController: UIViewController | ||
| private unowned let presentingViewController: UIViewController |
Contributor
There was a problem hiding this comment.
Did you chose unowned so the type didn't have to become wrapped in Optional?
Contributor
Author
There was a problem hiding this comment.
Indeed. Given this is a "presenter" type, it should not use the view controller reference if the view controller is released. If this unowned reference causes a runtime crash in the production app, I think we may have other issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #20989.
Issue
When done viewing a post from the Notifications tab, the post detail view isn't released.
To reproduce this issue:
viewDidLoadanddeinitfunctions inReaderDetailViewController.ReaderDetailViewController.ReaderDetailViewController.viewDidLoad. This step is just to confirm that theReaderDetailViewControllerhas been createdReaderDetailsViewController.deinit.Performing the above steps on the trunk branch doesn't hit the
deinitbreakpoint, which means the view controller is not released.You can test this PR by repeating the same steps on this PR branch and verify that Xcode stops at
deinitbreakpoint.Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
Viewing notifications and posts.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A