Fix memory leaks on viewing a post from a notification

crazytonyli · crazytonyli · commit e44432eb019f · 2023-07-06T10:24:29.000+12:00
diff --git a/WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsFollowPresenter.swift b/WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsFollowPresenter.swift
@@ -15,7 +15,7 @@ class ReaderCommentsFollowPresenter: NSObject {
 
     private let post: ReaderPost
     private weak var delegate: ReaderCommentsFollowPresenterDelegate?
-    private let presentingViewController: UIViewController
+    private unowned let presentingViewController: UIViewController
     private let followCommentsService: FollowCommentsService?
 
     // MARK: - Initialization
diff --git a/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsTableViewDelegate.swift b/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailCommentsTableViewDelegate.swift
@@ -7,7 +7,7 @@ class ReaderDetailCommentsTableViewDelegate: NSObject, UITableViewDataSource, UI
 
     private(set) var totalComments = 0
     private var post: ReaderPost?
-    private var presentingViewController: UIViewController?
+    private weak var presentingViewController: UIViewController?
     private weak var buttonDelegate: BorderedButtonTableViewCellDelegate?
     private(set) var headerView: ReaderDetailCommentsHeader?
     var followButtonTappedClosure: (() ->Void)?
diff --git a/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift b/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailHeaderView.swift
@@ -1,7 +1,7 @@
 import UIKit
 import AutomatticTracks
 
-protocol ReaderDetailHeaderViewDelegate {
+protocol ReaderDetailHeaderViewDelegate: AnyObject {
     func didTapBlogName()
     func didTapMenuButton(_ sender: UIView)
     func didTapHeaderAvatar()
@@ -43,7 +43,7 @@ class ReaderDetailHeaderView: UIStackView, NibLoadable {
 
     /// Any interaction with the header is sent to the delegate
     ///
-    var delegate: ReaderDetailHeaderViewDelegate?
+    weak var delegate: ReaderDetailHeaderViewDelegate?
 
     func configure(for post: ReaderPost) {
         self.post = post
diff --git a/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailLikesView.swift b/WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailLikesView.swift
@@ -1,6 +1,6 @@
 import UIKit
 
-protocol ReaderDetailLikesViewDelegate {
+protocol ReaderDetailLikesViewDelegate: AnyObject {
     func didTapLikesView()
 }
 
@@ -13,7 +13,7 @@ class ReaderDetailLikesView: UIView, NibLoadable {
     @IBOutlet private weak var selfAvatarImageView: CircularImageView!
 
     static let maxAvatarsDisplayed = 5
-    var delegate: ReaderDetailLikesViewDelegate?
+    weak var delegate: ReaderDetailLikesViewDelegate?
 
     /// Stores the number of total likes _without_ adding the like from self.
     private var totalLikes: Int = 0
