Skip to content

Fix/17344 - Close account error messages#17350

Merged
momo-ozawa merged 3 commits intorelease/18.5from
fix/17344-close-account-error-messages
Oct 21, 2021
Merged

Fix/17344 - Close account error messages#17350
momo-ozawa merged 3 commits intorelease/18.5from
fix/17344-close-account-error-messages

Conversation

@nikola-milicevic
Copy link
Copy Markdown
Contributor

@nikola-milicevic nikola-milicevic commented Oct 21, 2021

Fixes #17344

This PR adds more specific localized error message for different error types that can be encountered while trying to close the user account.

Test closing account with active subscription:

  1. Make sure logged in user has an active subscription
  2. Go to My Site > Profile > Account Settings > Close account
  3. Enter the username when prompted
  4. Closing account should fail with the following error message:

Screenshot 2021-10-21 at 15 11 21

Test closing account with atomic site

  1. Make sure logged in user has an atomic site, or is added as an admin to one
  2. Go to My Site > Profile > Account Settings > Close account
  3. The following error message should be displayed:

Screenshot 2021-10-21 at 15 14 07

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@nikola-milicevic nikola-milicevic added this to the Someday milestone Oct 21, 2021
@nikola-milicevic nikola-milicevic self-assigned this Oct 21, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 21, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Oct 21, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa approved these changes Oct 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! Thanks @nikola-milicevic 🙌

One important thing though, I remembered the Changes to the strings during the beta testing section in p77Llu-bLz-p2. This document is a bit old though, so I'm not sure what the current protocol is. (cc: @leandroalonso @mokagio)

I asked in Slack because I wasn't sure: p1634826656003100-slack-CC7L49W13

@momo-ozawa
Copy link
Copy Markdown
Contributor

momo-ozawa commented Oct 21, 2021 •
edited
Loading

@nikola-milicevic 👋
I'll be merging this into release/18.5 once CI completes, since it's EOD for you... and also because I wanted to make sure @mokagio has a chance to make a new beta with these changes + merge release/18.5 into develop before EOW.

Special thanks to @AliSoftware for helping to update the strings for localization! 🙇‍♀️

@momo-ozawa momo-ozawa modified the milestones: Someday, 18.5 ❄️ Oct 21, 2021
@momo-ozawa momo-ozawa added the /Me label Oct 21, 2021
@momo-ozawa momo-ozawa merged commit fc2adb8 into release/18.5 Oct 21, 2021
@momo-ozawa momo-ozawa deleted the fix/17344-close-account-error-messages branch October 21, 2021 15:47
@mokagio
Copy link
Copy Markdown
Contributor

mokagio commented Oct 22, 2021 •
edited
Loading

@momo-ozawa @nikola-milicevic this has been bundled as part of 18.5 beta 3 (18.5.0.3).

Thanks for your work 🙌

@nikola-milicevic
Copy link
Copy Markdown
Contributor Author

nikola-milicevic commented Oct 22, 2021

@momo-ozawa @AliSoftware @mokagio Thanks! 🎉

@ScoutHarris ScoutHarris mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nikola-milicevic nikola-milicevic

Labels

/Me

Projects

None yet

Milestone

18.5

Development

Successfully merging this pull request may close these issues.

4 participants

@nikola-milicevic @momo-ozawa @mokagio @AliSoftware