Skip to content

Change default app icon to spectrum#16673

Merged
Gio2018 merged 1 commit intorelease/17.5from
app-icon-to-spectrum
Jun 11, 2021
Merged

Change default app icon to spectrum#16673
Gio2018 merged 1 commit intorelease/17.5from
app-icon-to-spectrum

Conversation

@frosty
Copy link
Copy Markdown
Contributor

@frosty frosty commented Jun 11, 2021

This is a temporary change to update the default app icon to Spectrum. It make the following changes:

  • Adds blue (the normal default) as a proper custom icon, selectable in the App Icon settings screen. This is done by providing some extra icon files and adding entries to the Info.plist files. This will allow users to switch back to blue if they'd like to.
  • Adds a new AppIconSpectrum entry to the main asset catalog and updates the Info.plists and build settings to reference this new app icon as the default. Any user without a custom icon should be updated to this new icon.
  • Makes a small tweak to the AppIconViewController so that Spectrum is treated as the default and sorted to the top of the list.

To test

I can think of a number of situations to test:

No existing custom icon

  • Build and run an existing build of the app (I guess release/17.5). Do not select a custom icon.
  • Build and run this branch over the top, and you should see the app icon gets updated to Spectrum.
  • Visit the Me > App Settings > App Icon settings and ensure that spectrum is checked at the top and you can choose an alternative (including Blue).

Existing custom icon

  • Follow the steps above, but before installing this branch, set a custom icon to something else. Ensure that setting is respected when upgrading.

Reverting

  • Follow the steps in the no existing custom icon test, and don't choose a custom icon.
  • After installing these changes and running, build and run 17.5 again over the top.
  • The icon should revert back to blue and if you check the AppIconViewController, it should reflect that choice at the top of the list.

Reverting after switching back to blue

  • Follow the steps in the no existing custom icon test, and then manually switch your icon back to blue in the app settings..
  • Build and run 17.5 again over the top.
  • I'm hoping that the icon should revert back to blue and if you check the AppIconViewController, it should reflect that choice at the top of the list. I haven't had chance to check this yet.

Regression Notes

  1. Potential unintended areas of impact

This should only affect app icons.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)
  2. What automated tests I added (or what prevented me from doing so)

N / A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@frosty frosty added the General label Jun 11, 2021
@frosty frosty added this to the 17.5 ❄️ milestone Jun 11, 2021
@frosty frosty requested a review from Gio2018 June 11, 2021 17:44
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 11, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! I like that we are keeping the spectrum icon if that was set before updating to this version.

@Gio2018 Gio2018 merged commit 4921f39 into release/17.5 Jun 11, 2021
@Gio2018 Gio2018 deleted the app-icon-to-spectrum branch June 11, 2021 18:54
@frosty frosty mentioned this pull request Jun 17, 2021
4 tasks
guarani pushed a commit that referenced this pull request May 17, 2022
This PR is similar to #16673 and makes the default app icon spectrum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants