Change default app icon to spectrum#16673
Merged
Gio2018 merged 1 commit intorelease/17.5from Jun 11, 2021
Merged
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Gio2018
approved these changes
Jun 11, 2021
Contributor
Gio2018
left a comment
There was a problem hiding this comment.
This looks great!! I like that we are keeping the spectrum icon if that was set before updating to this version.
guarani
pushed a commit
that referenced
this pull request
May 17, 2022
This PR is similar to #16673 and makes the default app icon spectrum.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a temporary change to update the default app icon to Spectrum. It make the following changes:
blue(the normal default) as a proper custom icon, selectable in the App Icon settings screen. This is done by providing some extra icon files and adding entries to the Info.plist files. This will allow users to switch back to blue if they'd like to.AppIconViewControllerso that Spectrum is treated as the default and sorted to the top of the list.To test
I can think of a number of situations to test:
No existing custom icon
Existing custom icon
Reverting
Reverting after switching back to blue
Regression Notes
This should only affect app icons.
N / A
PR submission checklist:
RELEASE-NOTES.txtif necessary.