Skip to content

Jetpack Section: add events for backup / restore#15791

Merged
leandroalonso merged 13 commits intodevelopfrom
task/backup_restore_events
Feb 4, 2021
Merged

Jetpack Section: add events for backup / restore#15791
leandroalonso merged 13 commits intodevelopfrom
task/backup_restore_events

Conversation

@leandroalonso
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso commented Feb 4, 2021

Part of #15191

To test

  • Tap "Restore" from Activity Log and Backups screen and make sure the events are fired with the correct source property
  • Restore your site to any point and make sure the restore confirmed event is fired with the selected types
  • When restoring, tap the "notify me" button and make sure the correlated event is fired
  • Restore your site and turn off Wi-fi, make sure an event is fired with the cause property
  • Tap "Download Backup" from Activity Log and Backups screen and make sure the events are fired with the correct source property
  • Confirm a backup and make sure an event is fired with the selected types
  • Turn off wi-fi while a backup is being generated make sure an event is fired with the cause property
  • Tap the "notify me" button wile the backup is being generated and make sure the event is fired
  • When the backup is done, tap the download button and make sure an event is fired
  • Tap the share button and make sure the event is fired

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@leandroalonso leandroalonso added this to the 16.7 milestone Feb 4, 2021
@leandroalonso leandroalonso self-assigned this Feb 4, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 4, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 4, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

emilylaguna
emilylaguna approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the steps and confirmed each of them triggered the correct event and properties!

🚀

@leandroalonso leandroalonso merged commit 31cc302 into develop Feb 4, 2021
@leandroalonso leandroalonso deleted the task/backup_restore_events branch February 4, 2021 19:58
@emilylaguna emilylaguna mentioned this pull request Feb 5, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emilylaguna emilylaguna emilylaguna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leandroalonso leandroalonso

Labels

Analytics Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

2 participants

@leandroalonso @emilylaguna