Skip to content

Jetpack Section: Scan: Updates fix / ignore flow#15780

Merged
emilylaguna merged 2 commits intodevelopfrom
task/15190-scan-updated-fixing-state
Feb 4, 2021
Merged

Jetpack Section: Scan: Updates fix / ignore flow#15780
emilylaguna merged 2 commits intodevelopfrom
task/15190-scan-updated-fixing-state

Conversation

@emilylaguna
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna commented Feb 3, 2021

Project: #15190

This updates the fix / ignore flow to use the new flow introduced in: #15755

Demos

fix-flow.mov
ignore-flow.mov

To test:

  1. Launch the app
  2. Tap My Site
  3. Tap a site with Jetpack Scan enabled
  4. Tap on a threat to view its details
  5. Tap the Fix button
  6. You should be brought back to the main view and the state should display as fixing
  7. After a few seconds it should be updated to the idle state
  8. Tap another threat to view its details
  9. Tap the Ignore button
  10. You should see an async spinner
  11. Once it's ignored you are brought back to the main view and a message informing you it was fixed will be displayed

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@emilylaguna emilylaguna added this to the 16.7 milestone Feb 3, 2021
@emilylaguna emilylaguna self-assigned this Feb 3, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 3, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@emilylaguna emilylaguna mentioned this pull request Feb 3, 2021
Closed
55 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Feb 3, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa reviewed Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

❓ Should we show a success / error notice for the fix threat flow? Wondering because I think the web shows a notice and maybe Android as well?

@emilylaguna
Copy link
Copy Markdown
Contributor Author

emilylaguna commented Feb 4, 2021

@momo-ozawa I don't think we need it. The "fix all" flow already kind of handles this by displaying which item is being fixed and updates once its done.

@emilylaguna emilylaguna merged commit 3f4af5e into develop Feb 4, 2021
@emilylaguna emilylaguna deleted the task/15190-scan-updated-fixing-state branch February 4, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

+1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@emilylaguna emilylaguna

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.7

Development

Successfully merging this pull request may close these issues.

3 participants

@emilylaguna @momo-ozawa @leandroalonso