Jetpack Section: Scan: Adds threat fixing status#15755
Merged
emilylaguna merged 17 commits intodevelopfrom Feb 3, 2021
Merged
Conversation
added 11 commits
February 1, 2021 14:51
|
You can trigger an installable build for these changes by visiting CircleCI here. |
1 task
added 2 commits
February 1, 2021 17:02
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
momo-ozawa
reviewed
Feb 2, 2021
Contributor
There was a problem hiding this comment.
Hey @emilylaguna
When I tried fixing my site, one of the threats went from a "fixing" state to a "normal" state. I was expecting the threat to be removed from the list once it was fixed.
My site has 3 threats:
- the calendar plugin
- the SEO plugin
- the
Infect a File Threatoption turned on in the Jetpack Threats Tester plugin
fixall.mov
Contributor
Author
|
@momo-ozawa I've tried all I can possible try and have not been able to reproduce this issue on my end 😭 I'm thinking I'll put a pin in this and address if later on if it pops up again, thoughts? |
momo-ozawa
approved these changes
Feb 2, 2021
Contributor
Sounds good to me! 👍 |
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project: #15190
Related: wordpress-mobile/WordPressKit-iOS#342
Adds a new state that displays the threats that are actively being fixed.
Demo
fixing.with.description.mov
To test:
Note: You can generate a fixable threat by installing these plugins:
PR submission checklist:
RELEASE-NOTES.txtif necessary.