Notifications: route backup notification to Backups screen#15733
Merged
leandroalonso merged 3 commits intodevelopfrom Jan 29, 2021
Merged
Notifications: route backup notification to Backups screen#15733leandroalonso merged 3 commits intodevelopfrom
leandroalonso merged 3 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
momo-ozawa
approved these changes
Jan 29, 2021
Contributor
momo-ozawa
left a comment
There was a problem hiding this comment.
Works as described! 👍
Looks like you need to fix a unit test, but I'll go ahead and approve 😄
houndci-bot
reviewed
Jan 29, 2021
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15191
Additional information
In order to properly fix that we need to change the notification type returned by the API.
To test
PR submission checklist:
RELEASE-NOTES.txtif necessary.