Jetpack Section: Activity Detail Download Backup Button#15683
Merged
momo-ozawa merged 7 commits intodevelopfrom Jan 28, 2021
Merged
Jetpack Section: Activity Detail Download Backup Button#15683momo-ozawa merged 7 commits intodevelopfrom
momo-ozawa merged 7 commits intodevelopfrom
Conversation
added 5 commits
January 21, 2021 15:00
Change rewind button from custom to system and use default colors.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
43 tasks
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
emilylaguna
reviewed
Jan 21, 2021
| // TODO | ||
| guard let url = backup.url, | ||
| let downloadURL = URL(string: url) else { | ||
| return |
Contributor
There was a problem hiding this comment.
I wonder if in the future we should show an alert letting the user know their download URL didn't work. Thoughts?
emilylaguna
approved these changes
Jan 21, 2021
Contributor
emilylaguna
left a comment
There was a problem hiding this comment.
Very nice! Works very well for me!
I left a non blocking comment below
3 tasks
Base automatically changed from
task/15191-backup-restore-more-error-handling
to
develop
January 28, 2021 01:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #15191
Description:
Download backupbutton to Activity Detail VC for rewindable activitiesDownload filebutton in Restore Complete VCMerge instructions:
To test:
RestoreandDownload backupbuttonsDownload backupbuttonCreate downloadable fileand wait until your backup completesDownload filePR submission checklist:
RELEASE-NOTES.txtif necessary.