Skip to content

Jetpack Section: Backup Progress Details#15657

Merged
momo-ozawa merged 12 commits intodevelopfrom
task/15191-backup-restore-progress-details
Jan 20, 2021
Merged

Jetpack Section: Backup Progress Details#15657
momo-ozawa merged 12 commits intodevelopfrom
task/15191-backup-restore-progress-details

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Jan 18, 2021 •
edited
Loading

Part of #15191

Description:

  • Updated progress title for Restore Status
  • Added button action for Restore Complete (visit site)
  • Added button action for Backup Complete (share link)

Merge directions:

To test:

Restore: progress details + visit site

  1. My Site > Activity Log > rewindable activity cell
  2. Tap on ellipsis icon
  3. Tap on Restore
  4. Tap on Restore to this point
  5. Tap on Confirm
    • ✅ The progress title should update (i.e. starting, uploading files, etc...)
  6. Tap on Visit site
    • ✅ Should be able to open the site in an in-app browser

Backup: share link

  1. My Site > Activity Log > rewindable activity cell
  2. Tap on ellipsis icon
  3. Tap on Create downloadable file
  4. Tap on Share link
    • ✅ Should be able to share the link for the downloadable file
Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 49 23 Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 49 35 Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 49 44
Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 49 49 Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 50 44 Simulator Screen Shot - iPhone 12 Pro - 2021-01-17 at 11 50 54
Restore Complete (visit site) Backup Complete (share link)
Simulator Screen Shot - iPhone 12 Pro - 2021-01-18 at 10 07 42 Simulator Screen Shot - iPhone 12 Pro - 2021-01-18 at 09 56 44

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 16.6 milestone Jan 18, 2021
@momo-ozawa momo-ozawa self-assigned this Jan 18, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 18, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 18, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@momo-ozawa momo-ozawa mentioned this pull request Jan 18, 2021
Merged
3 tasks
leandroalonso
leandroalonso reviewed Jan 18, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-ozawa works as described!

I just had an issue though:

I performed a rewind and I guess the service was having some issues at this time. It never reached 100% (while in Calypso it completed and then I got the notification).

I'm not sure what might have caused that, but I'm just wondering if a bad return would prevent the polling from happening?

The next try worked just fine. :)

Base automatically changed from task/15191-restore-status to develop January 18, 2021 23:49
@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented Jan 19, 2021

@leandroalonso

I performed a rewind and I guess the service was having some issues at this time. It never reached 100% (while in Calypso it completed and then I got the notification).

I'm not sure what might have caused that, but I'm just wondering if a bad return would prevent the polling from happening?

Hmmm. Good to know. I'll address this in a different PR, thanks for the heads up!

Merge branch 'develop' into task/15191-backup-restore-progress-details
8546b70 
# Conflicts:
#	WordPress/Classes/Models/JetpackSiteRef.swift
#	WordPress/WordPressTest/RegisterDomainDetailsViewModelTests.swift
@momo-ozawa momo-ozawa merged commit 213bfce into develop Jan 20, 2021
@momo-ozawa momo-ozawa deleted the task/15191-backup-restore-progress-details branch January 20, 2021 00:04
@momo-ozawa momo-ozawa mentioned this pull request Jan 21, 2021
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

@emilylaguna emilylaguna Awaiting requested review from emilylaguna

Assignees

@momo-ozawa momo-ozawa

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.6

Development

Successfully merging this pull request may close these issues.

2 participants

@momo-ozawa @leandroalonso