Skip to content

Jetpack Section: Backup Status and Backup Complete#15633

Merged
momo-ozawa merged 8 commits intodevelopfrom
task/15191-backup-status
Jan 15, 2021
Merged

Jetpack Section: Backup Status and Backup Complete#15633
momo-ozawa merged 8 commits intodevelopfrom
task/15191-backup-status

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Jan 13, 2021 •
edited
Loading

Part of #15191

  • Hooked up download backup APIs
    • Prepare downloadable backups
    • Get backup status (poll for status every second)
  • Added a new Backup Complete screen

Notes:

  • Styling isn't 100% complete
  • Buttons on Backup Complete screen are not hooked up yet
  • Error handling will be addressed in a separate PR

To test:

  1. My Site > Activity Log > rewindable activity cell
  2. Tap on ellipsis icon
  3. Tap on Download Backup
  4. Tap on Create downloadable file
    • ✅ The progress view should update (roughly 0% → 77% → 88%)
    • ✅ Once the backup is ready to download, the app should transition to the Backup Complete screen
Screen.Recording.2021-01-13.at.19.55.21.mov

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 16.6 milestone Jan 13, 2021
@momo-ozawa momo-ozawa self-assigned this Jan 13, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 13, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@momo-ozawa momo-ozawa mentioned this pull request Jan 13, 2021
Closed
43 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 13, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

momo-ozawa
momo-ozawa commented Jan 13, 2021
View reviewed changes
...sses/ViewRelated/Jetpack/Jetpack Restore/Restore Status/JetpackBackupStatusCoordinator.swift
}

private func pollBackupStatus(for downloadID: Int) {
Timer.scheduledTimer(withTimeInterval: 1, repeats: true) { [weak self] timer in
Copy link
Copy Markdown
Contributor Author

@momo-ozawa momo-ozawa Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zwarm 👋
On Android, what polling interval are you using for fetching the backup status?
I'm polling the backup status every second (just for now)

emilylaguna
emilylaguna reviewed Jan 13, 2021
View reviewed changes
...sses/ViewRelated/Jetpack/Jetpack Restore/Restore Status/JetpackBackupStatusCoordinator.swift
private let site: JetpackSiteRef
private let view: JetpackBackupStatusView

init(site: JetpackSiteRef,
Copy link
Copy Markdown
Contributor

@emilylaguna emilylaguna Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, I had issues using the JetpackSiteRef for the scanning view because I later needed more metadata that the Blog entity contains. I recently switched to using Blog instead of JetpackSiteRef.

Not sure if you'll later need metadata such as site name, timezone, etc.

Copy link
Copy Markdown
Contributor Author

@momo-ozawa momo-ozawa Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good to know! Will switch to Blog instead if I end up needing that metadata. Thanks for the heads up! ❤️

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 14, 2021

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@momo-ozawa momo-ozawa mentioned this pull request Jan 14, 2021
Merged
3 tasks
@momo-ozawa momo-ozawa merged commit 3502105 into develop Jan 15, 2021
@momo-ozawa momo-ozawa deleted the task/15191-backup-status branch January 15, 2021 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

+1 more reviewer

@emilylaguna emilylaguna emilylaguna left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@momo-ozawa momo-ozawa

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

16.6

Development

Successfully merging this pull request may close these issues.

3 participants

@momo-ozawa @emilylaguna @leandroalonso