Skip to content

Jetpack Section: Add Warning and Restore Status screens#15598

Merged
momo-ozawa merged 12 commits intodevelopfrom
feature/15191-tap-action-button
Jan 12, 2021
Merged

Jetpack Section: Add Warning and Restore Status screens#15598
momo-ozawa merged 12 commits intodevelopfrom
feature/15191-tap-action-button

Conversation

@momo-ozawa
Copy link
Copy Markdown
Contributor

@momo-ozawa momo-ozawa commented Jan 7, 2021 •
edited
Loading

Part of #15191

  • Adds Warning skeleton screen
  • Adds Restore Status skeleton screen

⚠️ The following will be addressed in subsequent PRs:

  • Passing data
  • API hookup
  • Styling

To test:

  1. My Site > Activity Log > rewindable activity cell
  2. Tap on ellipsis icon
  3. Tap on Restore
  4. Tap on Restore to this point
    • ✅ Should display new Warning screen
  5. Tap on Confirm
    • ✅ Should display new Restore Status screen
Warning Restore Status
Screen Shot 2021-01-07 at 20 48 57 Screen Shot 2021-01-07 at 20 49 00

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the Someday milestone Jan 7, 2021
@momo-ozawa momo-ozawa self-assigned this Jan 7, 2021
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 7, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 7, 2021

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jan 7, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

leandroalonso
leandroalonso reviewed Jan 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandroalonso leandroalonso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momo-ozawa works as described, I spotted a few issues:

  • There are some hardcoded white colors that break the dark mode
  • When I increased the font size in Simulator, I wasn't able to tap the "Restore to this point" button. Not sure if it's just a local problem tho

Also, should we change the event detail to trigger this flow? The "Rewind" button:

@momo-ozawa momo-ozawa changed the title Feature/15191 tap action button Jetpack Section: add Warning and Restore Status screens Jan 7, 2021
@momo-ozawa momo-ozawa changed the title Jetpack Section: add Warning and Restore Status screens Jetpack Section: Add Warning and Restore Status screens Jan 7, 2021
houndci-bot
houndci-bot reviewed Jan 8, 2021
View reviewed changes
@momo-ozawa
Copy link
Copy Markdown
Contributor Author

momo-ozawa commented Jan 8, 2021 •
edited
Loading

@leandroalonso

There are some hardcoded white colors that break the dark mode

When I increased the font size in Simulator, I wasn't able to tap the "Restore to this point" button. Not sure if it's just a local problem tho

Fixed! 34bf558

Also, should we change the event detail to trigger this flow? The "Rewind" button:

Fixed! fce71bb

Restore Options Warning Restore Status
Screen Shot 2021-01-08 at 13 48 19 Screen Shot 2021-01-08 at 13 48 22 Screen Shot 2021-01-08 at 13 48 25

@momo-ozawa momo-ozawa mentioned this pull request Jan 8, 2021
Closed
43 tasks
@momo-ozawa momo-ozawa merged commit 0374294 into develop Jan 12, 2021
@momo-ozawa momo-ozawa deleted the feature/15191-tap-action-button branch January 12, 2021 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso leandroalonso approved these changes

@emilylaguna emilylaguna Awaiting requested review from emilylaguna

+1 more reviewer

@houndci-bot houndci-bot houndci-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@momo-ozawa momo-ozawa

Labels

Jetpack Mobile [Type] Task

Projects

None yet

Milestone

Someday

Development

Successfully merging this pull request may close these issues.

3 participants

@momo-ozawa @houndci-bot @leandroalonso