Jetpack Section: Present action sheet for backup and restore#15555
Jetpack Section: Present action sheet for backup and restore#15555momo-ozawa merged 9 commits intodevelopfrom
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
leandroalonso
left a comment
There was a problem hiding this comment.
@momo-ozawa works as described!
A question tho: styling is going to be added in a subsequent task? (the button has blue color, not grey). Also, I think we can improve two things:
- Make the button 44x44pt
- Add a margin on the left side of the button
This doesn't necessarily need to be done in this task, just keep that in mind for the near future. :)
|
|
||
| func presentRewindFor(activity: Activity) { | ||
| func presentDetailsFor(activity: FormattableActivity) { | ||
| let activityStoryboard = UIStoryboard(name: "Activity", bundle: nil) |
There was a problem hiding this comment.
I know this code was already here, but perhaps we can improve it by using StoryboardLoadable and removing this boilerplate code?
|
@momo-ozawa I merged I'm not going to touch #15566 because I'm not sure if you already have any local changes and I don't want to create issues for you. :) |
Part of #15191
.jetpackBackupAndRestorefeature flagActivityTableViewCellTo test:
.jetpackBackupAndRestorefeature flag ONRestore,Download Backupwon't do anything atm.jetpackBackupAndRestorefeature flag OFFPR submission checklist:
RELEASE-NOTES.txtif necessary.