Skip to content

Integrate gutenberg-mobile release 1.37.1#14945

Merged
cameronvoell merged 5 commits intodevelopfrom
gutenberg/integrate_release_1.37.1
Sep 19, 2020
Merged

Integrate gutenberg-mobile release 1.37.1#14945
cameronvoell merged 5 commits intodevelopfrom
gutenberg/integrate_release_1.37.1

Conversation

@ceyhun
Copy link
Copy Markdown
Contributor

@ceyhun ceyhun commented Sep 18, 2020 •
edited
Loading

Description

This PR incorporates the 1.37.1 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#2642

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

etoledom and others added 3 commits September 18, 2020 15:34
@etoledom
[Gutenberg] In case UBE request permission to login with WordPress.co…
7c46e48 
…m, now we will explicitly remove the WebView overlay to let the user see said screen.

Previously the overlay was covering the Login screen.
@etoledom
Fix lint issues
0e9edd6
@ceyhun
Merge pull request #14942 from wordpress-mobile/gutenberg/ube-fix-ove…
35e4e1d 
…rlay

[Gutenberg] UBE: Remove overlay if login with WordPress.com is requested.
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 35175. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@ceyhun ceyhun mentioned this pull request Sep 18, 2020
Merged
5 tasks
@ceyhun ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label Sep 18, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Sep 18, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@cameronvoell cameronvoell marked this pull request as ready for review September 18, 2020 19:54
@cameronvoell cameronvoell self-requested a review September 18, 2020 19:55
@StefanXhunga
Copy link
Copy Markdown

StefanXhunga commented Sep 18, 2020

Thank you for your assistance and help!

cameronvoell
cameronvoell approved these changes Sep 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tested and it and works well!

@cameronvoell cameronvoell added this to the 15.8 milestone Sep 19, 2020
@cameronvoell cameronvoell merged commit 8fae4e2 into develop Sep 19, 2020
@ceyhun ceyhun deleted the gutenberg/integrate_release_1.37.1 branch September 21, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cameronvoell cameronvoell cameronvoell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

4 participants

@ceyhun @StefanXhunga @cameronvoell @etoledom