[Gutenberg] UBE: Remove overlay if login with WordPress.com is requested.#14942
Merged
ceyhun merged 2 commits intogutenberg/integrate_release_1.37.1from Sep 18, 2020
Merged
Conversation
…m, now we will explicitly remove the WebView overlay to let the user see said screen. Previously the overlay was covering the Login screen.
houndci-bot
reviewed
Sep 18, 2020
WordPress/Classes/ViewRelated/Gutenberg/GutenbergWeb/GutenbergWebViewController.swift
Outdated
Show resolved
Hide resolved
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Sep 18, 2020
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
ceyhun
approved these changes
Sep 18, 2020
Contributor
ceyhun
left a comment
There was a problem hiding this comment.
Tested on iPhone 11, iOS 13 sim and works great 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gutenbergPR: WordPress/gutenberg#25449gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#2641This PR implements the changes from WordPress/gutenberg#25449 to remove the overlay from the Unsupported Block Editor web view, if
Login with WordPress.comis requested.To test:
Allow users to log in to this site using WordPress.com accounts)Login With WordPress.comscreen.PR submission checklist:
RELEASE-NOTES.txtif necessary.