Skip to content

Implement content info metrics (word, characters) in Gutenberg.#14305

Merged
SergioEstevao merged 9 commits intodevelopfrom
gutenberg/implement_word_count
Jun 17, 2020
Merged

Implement content info metrics (word, characters) in Gutenberg.#14305
SergioEstevao merged 9 commits intodevelopfrom
gutenberg/implement_word_count

Conversation

@SergioEstevao
Copy link
Copy Markdown
Contributor

@SergioEstevao SergioEstevao commented Jun 12, 2020 •
edited
Loading

Fixes: wordpress-mobile/gutenberg-mobile#506

GB-Mobile PR: wordpress-mobile/gutenberg-mobile#2380

To test:

  • Start the app
  • Open a post using the Block editor
  • Tap on the ... button on the top right
  • Check if the post metrics are displayed on the top of action sheet

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added [Type] Enhancement Gutenberg Editing and display of Gutenberg blocks. labels Jun 12, 2020
@SergioEstevao SergioEstevao added this to the 15.1 milestone Jun 12, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 12, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@SergioEstevao SergioEstevao mentioned this pull request Jun 12, 2020
Merged
2 tasks
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Jun 12, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

etoledom
etoledom reviewed Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

There seems to be a small but important detail I commented on code. The rest looks shinny ✨

@SergioEstevao
Copy link
Copy Markdown
Contributor Author

SergioEstevao commented Jun 15, 2020

There seems to be a small but important detail I commented on code. The rest looks shinny

I don't see the comment...

@etoledom
Copy link
Copy Markdown
Contributor

etoledom commented Jun 15, 2020

I don't see the comment...

@SergioEstevao - Sorry, I don't know what happened! I wrote it again 👍

@SergioEstevao SergioEstevao requested a review from etoledom June 15, 2020 15:31
@jkmassel
Copy link
Copy Markdown
Contributor

jkmassel commented Jun 15, 2020

Howdy friends – we're freezing 15.1 today, so I'm bumping this PR forward to 15.2. If it needs to land in the 15.1 series, please merge it to release/15.1 and DM me – I'll be happy to create a new beta release!

@jkmassel jkmassel modified the milestones: 15.1, 15.2 Jun 15, 2020
etoledom
etoledom approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great now! 🎉

I had to update from develop to be able to update the Pods.
Other than that, ✅

@SergioEstevao SergioEstevao mentioned this pull request Jun 16, 2020
Merged
2 tasks
@SergioEstevao SergioEstevao merged commit 9de79f2 into develop Jun 17, 2020
@SergioEstevao SergioEstevao deleted the gutenberg/implement_word_count branch June 17, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@etoledom etoledom etoledom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

15.2

Development

Successfully merging this pull request may close these issues.

Display word, character count on overflow menu Action Sheet

3 participants

@SergioEstevao @etoledom @jkmassel