[Gutenberg] Enable build from monorepo#14188
[Gutenberg] Enable build from monorepo#14188mchowning merged 11 commits intogutenberg/integrate_release_1.31.0from
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
Regression Testing progress: DarkMode-1
DarkMode-2
Group-1
Group-2
Spacer-1
Spacer-2
Buttons-1
Buttons-2
Buttons-3 Buttons-4
Button-5
Button-6
Button-7 |
|
This might be a bit random: While running from I noticed that the title gets prepopulated with "Welcome to gutenberg for WP Apps!" for a new post. |
It's intentional for the demo apps as mentioned here:
but shouldn't be the case for WP apps, it's probably because we're missing a check in the gutenberg-mobile PR, in this file: https://github.com/wordpress-mobile/gutenberg-mobile/pull/2172/files#diff-1fdf421c05c1140f6d71444ea2b27638R23 I'll fix it and update the gutenberg-mobile ref here 👍 |
|
@chipsnyder Can you please try again with this new gutenberg-mobile ref |
That fixed it. Thanks @ceyhun :) |
|
@ceyhun I came across an error when testing Following those steps I have:
Trying to add to group 3 pops the error here: Update: Tested this against |
|
While testing Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps I ran into an issue where the preview is hanging for one of my test sites (verified that this is working on a 15.1 test build)
Update: Tested this against |
….0' into gutenberg/try-enabling-build-from-monorepo
mchowning
left a comment
There was a problem hiding this comment.
Did a quick sanity check and everything looks good to me.
SergioEstevao
left a comment
There was a problem hiding this comment.
Looking good! I smoke test the GB editor writing flow, and all is looking correct.


Description
This PR adds the necessary changes for building WordPress-iOS using the new Gutenberg/Gutenberg-Mobile Monorepo setup.
Related PR's:
Gutenberg Monorepo PR's for fixing WPiOS build
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.