[RNMobile][Monorepo] Make the native app customizable by a parent app#21332
Merged
hypest merged 52 commits intofeat/import-gutenberg-mobile-no-squashfrom Jun 17, 2020
Merged
Conversation
1e09ea8 to
ef169ed
Compare
|
Size Change: 0 B Total Size: 828 kB ℹ️ View Unchanged
|
22 tasks
4c2b6b2 to
2541642
Compare
…squash' into rnmobile/experiment-monorepo-new-setup
…ps from the parent app or not
57e7ad6 to
2cfee15
Compare
3 tasks
ceyhun
reviewed
May 20, 2020
gziolo
reviewed
Jun 17, 2020
| import { cloneElement } from './react'; | ||
|
|
||
| const render = ( element, id ) => | ||
| AppRegistry.registerComponent( id, () => ( propsFromParent ) => { |
Member
There was a problem hiding this comment.
Out of curiosity, why not to execute all this logic inside initializeEditor in the @wordpress/edit-post package?
Overriding React methods and adding WP hooks might have some performance implications but I guess it’s called only once.
Member
There was a problem hiding this comment.
I think it's to be able to customize the editor from an outside package. In this case a repo that's importing Gutenberg as a submodule. Correct me if I'm wrong @Tug?
Contributor
Author
There was a problem hiding this comment.
No we could totally have this logic in @wordpress/edit-post (or in @wordpress/react-native-editor as it was the case in the monorepo branch before this PR).
The idea here is simply to get closer to having @wordpress/edit-post work as cross-platform package. If you look at edit-post/src/index.native.js
you'll see that the init code is much closer to the web one now.
Overriding React methods and adding WP hooks might have some performance implications but I guess it’s called only once.
We're not overriding anything though, the render function wasn't defined for native prior to this. And yes it's only rendered once on load.
Member
There was a problem hiding this comment.
It probably doesn't matter as much then now, but I guess initializeEditor would be the best place to run all those side effects.
Member
cameronvoell
approved these changes
Jun 17, 2020
Contributor
|
Will now merge with "Use merge commit" strategy and revert back to "squash/rebase strategy" right after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does multiple changes which allows external native apps to reuse and customize the native block editor.
The main repo which customizes WordPress apps for Android and iOS is still gutenberg-mobile.
Here is the related PR for this integration: wordpress-mobile/gutenberg-mobile#2172
List of changes:
rendermethod in react platform to mimick the web API. Update the code inedit-postto use this new methodrendermethod to customize root component props and run pre render initialization codepackages/react-native-bridge/android/build.gradleto make WPAndroid build (switch from yarn to npm, update paths...)packages/react-native-bridge/android/vendor/hermes-engineso we can build WPAndroid using jitpack and a jsbundle without runningnpm installHow has this been tested?
See Gutenberg mobile PR
Types of changes
React native changes
Checklist: