Gutenberg - Starter Page Templates Tooltip#14045
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
added 2 commits
May 6, 2020 09:28
# Conflicts: # Podfile # Podfile.lock
added 2 commits
May 12, 2020 12:49
# Conflicts: # Podfile # Podfile.lock
houndci-bot
reviewed
May 12, 2020
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
Outdated
Show resolved
Hide resolved
added 2 commits
May 12, 2020 13:15
added 2 commits
May 19, 2020 09:03
# Conflicts: # Podfile # Podfile.lock
chipsnyder
reviewed
May 19, 2020
Contributor
|
Looks good functionally 👍. |
added 2 commits
May 21, 2020 11:53
# Conflicts: # Podfile # Podfile.lock # WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift
added 3 commits
May 21, 2020 12:33
# Conflicts: # Podfile.lock
chipsnyder
approved these changes
May 22, 2020
Contributor
chipsnyder
left a comment
There was a problem hiding this comment.
LGTM and is working as described. Thanks for the changes @geriux!
# Conflicts: # Podfile.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#2169
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2216Gutenberg PR-> WordPress/gutenberg#21974WordPress Android PR-> wordpress-mobile/WordPress-Android#11807To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.