[RNMobile] - Tooltip for template selection buttons#21974
Merged
Conversation
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
added 5 commits
April 30, 2020 15:28
mkevins
reviewed
May 18, 2020
packages/block-editor/src/components/page-template-picker/picker.native.js
Outdated
Show resolved
Hide resolved
mkevins
approved these changes
May 26, 2020
Contributor
mkevins
left a comment
There was a problem hiding this comment.
Tested via steps provided and everything works as expected. LGTM! 👍
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR-> wordpress-mobile/gutenberg-mobile#2216WordPress iOS PR-> wordpress-mobile/WordPress-iOS#14045WordPress Android PR-> wordpress-mobile/WordPress-Android#11807Description
This PR closes wordpress-mobile/gutenberg-mobile#2169
Adds a Tooltip to point to the template selection buttons. The component itself has a simple logic and it is attached to the Picker component. If we need another tooltip within the editor we could use this as a base and make it reusable.
How has this been tested?
Steps to test
Screenshots
UX Interaction
iOS Screenshots
Android Screenshots
Types of changes
Checklist: