Skip to content

Integrates WPKit and WPAuth into 14.3.#13589

Merged
diegoreymendez merged 1 commit intorelease/14.3from
try/fix-email-checking-for-14.3
Mar 5, 2020
Merged

Integrates WPKit and WPAuth into 14.3.#13589
diegoreymendez merged 1 commit intorelease/14.3from
try/fix-email-checking-for-14.3

Conversation

@diegoreymendez
Copy link
Copy Markdown
Contributor

Same as #13585 but for 14.3.

Use the same testing steps.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@diegoreymendez diegoreymendez requested a review from jkmassel March 4, 2020 10:06
@diegoreymendez diegoreymendez self-assigned this Mar 4, 2020
@peril-wordpress-mobile
Copy link
Copy Markdown

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Copy Markdown
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Invalid emails are properly handled (@mailinator.com)
✅ Taken emails also get properly handled
✅ Valid emails get the proper signup treatment!!

Nice work Diego!!!

:shipit: 🔥

@diegoreymendez diegoreymendez merged commit 88e1aec into release/14.3 Mar 5, 2020
@diegoreymendez diegoreymendez deleted the try/fix-email-checking-for-14.3 branch March 5, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants