Integrates new versions of WPKit and WPAuth to fix a signup issue.#13585
Merged
jkmassel merged 5 commits intorelease/14.2.1from Mar 3, 2020
Merged
Integrates new versions of WPKit and WPAuth to fix a signup issue.#13585jkmassel merged 5 commits intorelease/14.2.1from
jkmassel merged 5 commits intorelease/14.2.1from
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
Merged
1 task
1 task
jkmassel
approved these changes
Mar 3, 2020
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
I tested according to the test plan, and everything works as expected.
Also – we're referencing all pods by version, so the code is good to go.
Will merge when green.
Contributor
Author
|
Thanks @jkmassel ! |
This was referenced Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13583
This PR improves the error handling so that we don't ignore some error responses.
Testing:
Test 1:
Try signing up with a valid email account. It should send you the magic link.
Test 2:
Try signing up with an invalid email provider. For example "tester@mailinator.com".
You should see an error prompting you to use a different email provider.
Test 3:
Try singing up with a used email address (you can try with the email of your existing account).
You should see an error letting you know the email address is not available.
PR submission checklist:
RELEASE-NOTES.txtif necessary.