Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
Contributor
Author
|
✅ I tried to create a Spacer block and update the settings (with the updated range component) |
SergioEstevao
approved these changes
Nov 28, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Run the following tests on iOS:
[x] Full screen preview of image
[x] Test different images size
[x] Tested the space block
[x] Generally tested the writing flow
All working fine! 
cameronvoell
approved these changes
Nov 29, 2019
Contributor
cameronvoell
left a comment
There was a problem hiding this comment.
Double checked that issue with images with missing URLs disappearing is gone after last gutenberg update. Smoke tests look good as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1627
Changes:
PR submission checklist:
RELEASE-NOTES.txtif necessary.