Enables native image fullscreen preview on iOS#1597
Merged
cameronvoell merged 7 commits intodevelopfrom Nov 21, 2019
Merged
Conversation
…w for for an image from a URL on iOS.
etoledom
approved these changes
Nov 21, 2019
Contributor
etoledom
left a comment
There was a problem hiding this comment.
Looks good and works great 🎉
I left a small comment to be fixed before merging 👍
react-native-gutenberg-bridge/ios/RNReactNativeGutenbergBridge.m
Outdated
Show resolved
Hide resolved
This was referenced Nov 21, 2019
This was referenced Nov 27, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1286
WordPress-iOSPR: wordpress-mobile/WordPress-iOS#12979gutenbergPR: WordPress/gutenberg#18618Description
This change enables a call to native fullscreen image previews on iOS from the mobile image block. It also fixes some minor UX issues around not highlighting the image while caption is selected and not launching fullscreen image on tap when caption is selected (See #1286 (comment) ).
Testing
RELEASE-NOTES.txt.