Skip to content

[Gutenberg] Image Size networking#12706

Closed
etoledom wants to merge 2 commits intodevelopfrom
try/gutenberg-image-size-networking
Closed

[Gutenberg] Image Size networking#12706
etoledom wants to merge 2 commits intodevelopfrom
try/gutenberg-image-size-networking

Conversation

@etoledom
Copy link
Copy Markdown
Contributor

@etoledom etoledom commented Oct 16, 2019

This PR implements the changes on the gutenberg bridge to send the wpcom headers and site slug/id to gutenberg.

gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1453
gutenberg PR: WordPress/gutenberg#17979
WPKit PR:

To test:

  • Add a image block to gutenberg.
  • Select an image from the WordPress media Library.
  • Select settings and choose a different image setting.
  • Change to HTML mode.
  • Check that the image URL has changes according to the selected image size.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Oct 16, 2019
@etoledom etoledom added this to the 13.6 milestone Oct 16, 2019
@etoledom etoledom self-assigned this Oct 16, 2019
This was referenced Oct 16, 2019
Closed
Merged
Closed
Merged
@loremattei loremattei modified the milestones: 13.6 ❄️, 13.7 Nov 4, 2019
@loremattei loremattei modified the milestones: 13.7 ❄️, 13.8 Nov 18, 2019
@loremattei
Copy link
Copy Markdown
Contributor

loremattei commented Nov 18, 2019

Hey there! I've moved this to 13.8 since 13.7 has been cut. If you want this to make it to 13.7, please feel free to ping me.

@etoledom
Copy link
Copy Markdown
Contributor Author

etoledom commented Nov 19, 2019

Closing in favor of #12714

@etoledom etoledom closed this Nov 19, 2019
@peril-wordpress-mobile
Copy link
Copy Markdown

peril-wordpress-mobile bot commented Nov 19, 2019

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS

@etoledom etoledom deleted the try/gutenberg-image-size-networking branch June 2, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@etoledom etoledom

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

13.8 ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@etoledom @loremattei