[RNMobile] Implement getMedia on Image block.#17979
Merged
Conversation
This was referenced Oct 16, 2019
4084672 to
d903803
Compare
d903803 to
85f97ef
Compare
Contributor
|
Hey @etoledom ! I rebased your changes on top of |
SergioEstevao
approved these changes
Nov 18, 2019
Contributor
SergioEstevao
left a comment
There was a problem hiding this comment.
Tested it on iOS and it's working great.
ff6afda to
d3646fe
Compare
1a061a8 to
df26429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Image Sizes settings on the image block.
Previously we were showing the settings UI, and setting the selected slug in the store. With this PR we now can get the image url to use with the corresponding image size.
On the RN-Mobile side, we have decided to implement networking on the native side. These are the PRs that allows us to do networking this way:
gutenberg-mobilePR wordpress-mobile/gutenberg-mobile#1455WPiOS PR: wordpress-mobile/WordPress-iOS#12714
WPAndroid PR: wordpress-mobile/WordPress-Android#10779